lukechilds/node - node - Gitea: Git with a cup of tea

12320 Commits

131 Branches

446 Tags

325 MiB

Tree: 3bb4437abb

Commit Graph

Author	SHA1	Message	Date
Fedor Indutny	798dad24f4	child_process: `null` channel handle on close `HandleWrap::OnClose` destroys the underlying C++ object and null's the internal field pointer to it. Therefore there should be no references to the wrapping JavaScript object. `null` the process' `_channel` field right after closing it, to ensure no crashes will happen. Fix: https://github.com/nodejs/node/issues/2847 PR-URL: https://github.com/nodejs/node/pull/3041 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	9 years ago

Author

SHA1

Message

Date

Fedor Indutny

798dad24f4

child_process: `null` channel handle on close

`HandleWrap::OnClose` destroys the underlying C++ object and null's the
internal field pointer to it. Therefore there should be no references to
the wrapping JavaScript object.

`null` the process' `_channel` field right after closing it, to ensure
no crashes will happen.

Fix: https://github.com/nodejs/node/issues/2847
PR-URL: https://github.com/nodejs/node/pull/3041
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

9 years ago

1 Commits (3bb4437abb49cae570ac42b39780182bd73719a9)