lukechilds/node - node - Gitea: Git with a cup of tea

18830 Commits

131 Branches

446 Tags

325 MiB

Tree: 3c4c0db26a

Commit Graph

Author	SHA1	Message	Date
Anna Henningsen	bdaa2cb585	test: add regression test for 5691 With `CallbackScope`, this has become possible to do properly. Fixes: https://github.com/nodejs/node/issues/5691 PR-URL: https://github.com/nodejs/node/pull/14697 Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Anna Henningsen	64616bb769	src: refactor async callback handling - Merge the two almost-but-not-quite identical `MakeCallback()` implementations - Provide a public `CallbackScope` class for embedders in order to enable `MakeCallback()`-like behaviour without tying that to calling a JS function PR-URL: https://github.com/nodejs/node/pull/14697 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

Anna Henningsen

bdaa2cb585

test: add regression test for 5691

With `CallbackScope`, this has become possible to do properly.

Fixes: https://github.com/nodejs/node/issues/5691
PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Anna Henningsen

64616bb769

src: refactor async callback handling

- Merge the two almost-but-not-quite identical `MakeCallback()`
  implementations
- Provide a public `CallbackScope` class for embedders in order
  to enable `MakeCallback()`-like behaviour without tying that
  to calling a JS function

PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

2 Commits (3c4c0db26abba8211c0e6d42c14f14b3514b481b)