lukechilds/node - node - Gitea: Git with a cup of tea

16628 Commits

131 Branches

446 Tags

325 MiB

Tree: 3d21bfe6b9

Commit Graph

Author	SHA1	Message	Date
Mark	96babb2090	test: tests for _readableStream.awaitDrain Fixes: https://github.com/nodejs/node/issues/8684 PR-URL: https://github.com/nodejs/node/pull/8914 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	8 years ago
David Halls	b5175e8f39	stream: ensure awaitDrain is increased once Guard against the call to write() inside pipe's ondata pushing more data back onto the Readable, thus causing ondata to be called again. This is fine but results in awaitDrain being increased more than once. The problem with that is when the destination does drain, only a single 'drain' event is emitted, so awaitDrain in this case will never reach zero and we end up with a permanently paused stream. Fixes: https://github.com/nodejs/node/issues/7278 PR-URL: https://github.com/nodejs/node/pull/7292 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago

Author

SHA1

Message

Date

Mark

96babb2090

test: tests for _readableStream.awaitDrain

Fixes: https://github.com/nodejs/node/issues/8684
PR-URL: https://github.com/nodejs/node/pull/8914
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8 years ago

David Halls

b5175e8f39

stream: ensure awaitDrain is increased once

Guard against the call to write() inside pipe's ondata pushing more data
back onto the Readable, thus causing ondata to be called again.

This is fine but results in awaitDrain being increased more than once.
The problem with that is when the destination does drain, only a single
'drain' event is emitted, so awaitDrain in this case will never reach
zero and we end up with a permanently paused stream.

Fixes: https://github.com/nodejs/node/issues/7278
PR-URL: https://github.com/nodejs/node/pull/7292
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

9 years ago

2 Commits (3d21bfe6b94b6214563bbc5a9dc25da241c8e9d8)