lukechilds/node - node - Gitea: Git with a cup of tea

1581 Commits

131 Branches

446 Tags

325 MiB

Tree: 3fed1cf36f

Commit Graph

Author	SHA1	Message	Date
isaacs	31ed37fdf0	evalcx shouldn't be too fancy After getting some feedback from Mikeal Rogers and Tim Smart, it was decided that evalcx should not try to do any fancy security stuff, and instead leave that in the hands of the user. To comply more with spidermonkey, everything is passed in, and objects are passed in by reference rather than being cloned.	15 years ago
isaacs	943b2c61a8	Make evalcx work like it's supposed to. 1. Move the context->Enter() call so that the global obj is available for writing. 2. On success, copy the modified global out to the sandbox object. 3. Don't copy functions in either direction. They have scope and closures, and make for craziness when trying to keep contexts separate. 4. Only do the ->ToObject->Clone() on objects, so that simple values stay simple. 5. Update the test so that it tests all this stuff.	15 years ago
Tim-Smart	ae10a48383	Initial implementation of process.evalcx	15 years ago

Author

SHA1

Message

Date

isaacs

31ed37fdf0

evalcx shouldn't be too fancy

After getting some feedback from Mikeal Rogers and Tim Smart, it was decided
that evalcx should not try to do any fancy security stuff, and instead leave
that in the hands of the user. To comply more with spidermonkey, everything
is passed in, and objects are passed in by reference rather than being
cloned.

15 years ago

isaacs

943b2c61a8

Make evalcx work like it's supposed to.

1. Move the context->Enter() call so that the global obj is available for writing.
2. On success, copy the modified global out to the sandbox object.
3. Don't copy functions in either direction.  They have scope and closures, and make for craziness when trying to keep contexts separate.
4. Only do the ->ToObject->Clone() on objects, so that simple values stay simple.
5. Update the test so that it tests all this stuff.

15 years ago

Tim-Smart

ae10a48383

Initial implementation of process.evalcx

15 years ago

3 Commits (3fed1cf36fe6799b5987d376334d29dd7b7f70e8)