lukechilds/node - node - Gitea: Git with a cup of tea

15943 Commits

131 Branches

446 Tags

325 MiB

Tree: 406e623b13

Commit Graph

Author	SHA1	Message	Date
Michaël Zasso	0605c74538	test: refactor test-crypto-timing-safe-equal Add RegExp arguments to throws assertions. PR-URL: https://github.com/nodejs/node/pull/9843 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
not-an-aardvark	d0e61d4cc3	test: make crypto.timingSafeEqual test less flaky The `crypto.timingSafeEqual` test still seems to be a bit flaky. This makes a few changes to the test: * Separates the basic usage and the benchmarking into different tests * Moves the timing-sensitive benchmark function into a separate module, and reparses the module on every iteration of the loop to avoid shared state between timing measurements. PR-URL: https://github.com/nodejs/node/pull/8456 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
not-an-aardvark	afb9917f16	crypto: add crypto.timingSafeEqual() Reinstate crypto.timingSafeEqual() which was reverted due to test issues. The flaky test issues are resolved in this new changeset. PR-URL: https://github.com/nodejs/node/pull/8304 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago

Author

SHA1

Message

Date

Michaël Zasso

0605c74538

test: refactor test-crypto-timing-safe-equal

Add RegExp arguments to throws assertions.

PR-URL: https://github.com/nodejs/node/pull/9843
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

not-an-aardvark

d0e61d4cc3

test: make crypto.timingSafeEqual test less flaky

The `crypto.timingSafeEqual` test still seems to be a bit flaky. This
makes a few changes to the test:

* Separates the basic usage and the benchmarking into different tests

* Moves the timing-sensitive benchmark function into a separate module,
and reparses the module on every iteration of the loop to avoid shared
state between timing measurements.

PR-URL: https://github.com/nodejs/node/pull/8456
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

not-an-aardvark

afb9917f16

crypto: add crypto.timingSafeEqual()

Reinstate crypto.timingSafeEqual() which was reverted due to test
issues. The flaky test issues are resolved in this new changeset.

PR-URL: https://github.com/nodejs/node/pull/8304
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

9 years ago

3 Commits (406e623b139c4ab9e6914deaabac86b8eda5f555)