lukechilds/node - node - Gitea: Git with a cup of tea

16596 Commits

131 Branches

446 Tags

325 MiB

Tree: 40a61e1399

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Rich Trott	898276b1b4	test: simplify output handling in repl tests Replace .map() + .replace().trim() with a single .replace(). PR-URL: https://github.com/nodejs/node/pull/11124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>	8 years ago
cjihrig	6e6cf36761	repl: default useGlobal to true This is a partial revert of `15157c3c3d`. This change lead to a regression that broke require() in the CLI REPL, as imported files were evaluated in a different context. Refs: https://github.com/nodejs/node/pull/5703 Fixes: https://github.com/nodejs/node/issues/7788 PR-URL: https://github.com/nodejs/node/pull/7795 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>	9 years ago

Rich Trott

898276b1b4

test: simplify output handling in repl tests

Replace .map() + .replace().trim() with a single .replace().

PR-URL: https://github.com/nodejs/node/pull/11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

8 years ago

cjihrig

6e6cf36761

repl: default useGlobal to true

This is a partial revert of
15157c3c3d. This change lead to a
regression that broke require() in the CLI REPL, as imported
files were evaluated in a different context.

Refs: https://github.com/nodejs/node/pull/5703
Fixes: https://github.com/nodejs/node/issues/7788
PR-URL: https://github.com/nodejs/node/pull/7795
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

9 years ago

2 Commits (40a61e13994761aa91c13a71df97ccba57d33b2b)