lukechilds/node - node - Gitea: Git with a cup of tea

13849 Commits

131 Branches

446 Tags

325 MiB

Tree: 4369055878

Commit Graph

Author	SHA1	Message	Date
Bartosz Sosnowski	046d651118	benchmark: fix child-process-exec-stdout on win This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: https://github.com/nodejs/node/pull/7178 Reviewed-By: Trott - Rich Trott <rtrott@gmail.com> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>	9 years ago
Rich Trott	8eb18e4289	child_process: measure buffer length in bytes This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: https://github.com/nodejs/node/pull/6764 Fixes: https://github.com/nodejs/node/issues/1901 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago

Author

SHA1

Message

Date

Bartosz Sosnowski

046d651118

benchmark: fix child-process-exec-stdout on win

This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.

PR-URL: https://github.com/nodejs/node/pull/7178
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>

9 years ago

Rich Trott

8eb18e4289

child_process: measure buffer length in bytes

This change fixes a known issue where `maxBuffer` limits by characters
rather than bytes. Benchmark added to confirm no performance regression
occurs with this change.

PR-URL: https://github.com/nodejs/node/pull/6764
Fixes: https://github.com/nodejs/node/issues/1901
Reviewed-By: Brian White <mscdex@mscdex.net>

9 years ago

2 Commits (43690558787db5230634c77cfe053a0479714fcc)