lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
cjihrig	04b4d15b39	test: use mustCall() for simple flow tracking Many of the tests use variables to track when callback functions are invoked or events are emitted. These variables are then asserted on process exit. This commit replaces this pattern in straightforward cases with common.mustCall(). This makes the tests easier to reason about, leads to a net reduction in lines of code, and uncovered a few bugs in tests. This commit also replaces some callbacks that should never be called with common.fail(). PR-URL: https://github.com/nodejs/node/pull/7753 Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	9 years ago
Rich Trott	082cc8d6d8	test: remove unnecessary assignments common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. PR-URL: https://github.com/nodejs/node/pull/4408 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Rich Trott	ae8d436623	test: use reserved IP in test-net-connect-timeout Use reserved IP in test-net-connect-timeout.js rather than arbitrary IP. PR-URL: https://github.com/nodejs/node/pull/2257 Fixes: https://github.com/nodejs/node/issues/2469 Reviewed By: Ben Noordhuis <ben@strongloop.com>	10 years ago
Rich Trott	c786d6341d	test: do not use public IPs for timeout testing PR-URL: https://github.com/nodejs/io.js/pull/2057 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Roman Reiss	fb8811d95e	lib,test: fix whitespace issues PR-URL: https://github.com/nodejs/io.js/pull/1971 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
isaacs	3e1b1dd4a9	Remove excessive copyright/license boilerplate The copyright and license notice is already in the LICENSE file. There is no justifiable reason to also require that it be included in every file, since the individual files are not individually distributed except as part of the entire package.	10 years ago
isaacs	1b870b6127	test: Move test-net-connect-timeout to test/internet It is not a valid test unless you're connected to the internet, and causes a lot of spurious failures on Linux anyway, as it's highly dependent on timing of things that we don't have any control over.	12 years ago
Colton Baker	87286cc737	Fixed a lot of jslint errors. Fixes #1831	13 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Ryan Dahl	5f5201db2f	Fix test-net-connect-buffer Change to end() behavior in 33c339 was breaking it. end() should wait for connection before dumping. Changed test-net-connect-timeout to use destroy() instead.	14 years ago
Ryan Dahl	5f795efd4e	net: Timeouts should work before DNS resolution	14 years ago
Ryan Dahl	33c33949b2	Add test for connection timeouts Also make socket.end() destroy connection if still trying to connect. Previously was ignoring.	14 years ago