lukechilds/node - node - Gitea: Git with a cup of tea

8528 Commits

131 Branches

446 Tags

325 MiB

Tree: 469a4a5091

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	fb3ec32b0e	net: use close callback, not process.nextTick Don't emit the 'close' event with process.nextTick. Closing a handle is an operation that usually but not always completes on the next tick of the event loop, hence using process.nextTick is not reliable. Use a proper handle close callback and emit the 'close' event from inside the callback. Update tests that depend on the intricacies of the old model. Fixes #3459.	12 years ago
isaacs	987338fe31	http: Do not let Agent hand out destroyed sockets Fix #4373	12 years ago

Author

SHA1

Message

Date

Ben Noordhuis

fb3ec32b0e

net: use close callback, not process.nextTick

Don't emit the 'close' event with process.nextTick.

Closing a handle is an operation that usually *but not always* completes
on the next tick of the event loop, hence using process.nextTick is not
reliable.

Use a proper handle close callback and emit the 'close' event from
inside the callback.

Update tests that depend on the intricacies of the old model.

Fixes #3459.

12 years ago

isaacs

987338fe31

http: Do not let Agent hand out destroyed sockets

Fix #4373

12 years ago

2 Commits (469a4a5091a677df62be319675056b869c31b35c)