lukechilds/node - node - Gitea: Git with a cup of tea

18523 Commits

131 Branches

446 Tags

325 MiB

Tree: 4766fcb96d

Commit Graph

Author	SHA1	Message	Date
Rich Trott	28a47aa1bb	test: fix test-cluster-send-handle-large-payload On macOS, the parent process might not receive a message if it is sent to soon, and then subsequent messages are also sometimes not received. (Is this a bug or expected operating system behavior like the way a file watcher is returned before it's actually watching the file system on/ macOS?) Send a second message after a delay on macOS. While at it, minor refactoring to the test: * Blank line after loading `common` module per test-writing guide * Wrap arrow function in braces where implicit return is not needed * Remove unnecessary unref in subprocess PR-URL: https://github.com/nodejs/node/pull/14780 Fixes: https://github.com/nodejs/node/issues/14747 Reviewed-By: Anna Henningsen <anna@addaleax.net>	8 years ago
Anna Henningsen	611851daba	child_process: fix handle passing w large payloads Fix situations in which the handle passed along with a message that has a large payload and can’t be read entirely by a single `recvmsg()` call isn’t associated with the message to which it belongs. PR-URL: https://github.com/nodejs/node/pull/14588 Fixes: https://github.com/nodejs/node/issues/13778 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	8 years ago

Author

SHA1

Message

Date

Rich Trott

28a47aa1bb

test: fix test-cluster-send-handle-large-payload

On macOS, the parent process might not receive a message if it
is sent to soon, and then subsequent messages are also sometimes not
received.

(Is this a bug or expected operating system behavior like the
way a file watcher is returned before it's actually watching the file
system on/ macOS?)

Send a second message after a delay on macOS.

While at it, minor refactoring to the test:

* Blank line after loading `common` module per test-writing guide
* Wrap arrow function in braces where implicit return is not needed
* Remove unnecessary unref in subprocess

PR-URL: https://github.com/nodejs/node/pull/14780
Fixes: https://github.com/nodejs/node/issues/14747
Reviewed-By: Anna Henningsen <anna@addaleax.net>

8 years ago

Anna Henningsen

611851daba

child_process: fix handle passing w large payloads

Fix situations in which the handle passed along with a message
that has a large payload and can’t be read entirely by a single
`recvmsg()` call isn’t associated with the message to which it
belongs.

PR-URL: https://github.com/nodejs/node/pull/14588
Fixes: https://github.com/nodejs/node/issues/13778
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

8 years ago

2 Commits (4766fcb96d9459b7db8fb201d6ac44d6957b4df0)