lukechilds/node - node - Gitea: Git with a cup of tea

16489 Commits

131 Branches

446 Tags

325 MiB

Tree: 49c5ff4408

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
cjihrig	775de9cc96	test: improve module version mismatch error check Refs: https://github.com/nodejs/node/pull/10606 PR-URL: https://github.com/nodejs/node/pull/10636 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	8 years ago
Daniel Bevenius	9bb250ba34	test: enable node-module-version/test.js with debug Commit `fdca79fbc0` ("test: enable addons test to pass with debug build") enabled the addons tests to pass when the build type is of type debug (configure --debug). test/addons/node-module-version/test.js was recently added and expects the the build type to be of type Release (like most of the others until recently). This commit allows this test to pass when the build type if of type debug. PR-URL: https://github.com/nodejs/node/pull/9093 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
James M Snell	a6e1be4a4e	src: update module version mismatch error message Fixes: https://github.com/nodejs/node/issues/8379 PR-URL: https://github.com/nodejs/node/pull/8391 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>	9 years ago

cjihrig

775de9cc96

test: improve module version mismatch error check

Refs: https://github.com/nodejs/node/pull/10606
PR-URL: https://github.com/nodejs/node/pull/10636
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

8 years ago

Daniel Bevenius

9bb250ba34

test: enable node-module-version/test.js with debug

Commit fdca79fbc0 ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: https://github.com/nodejs/node/pull/9093
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

James M Snell

a6e1be4a4e

src: update module version mismatch error message

Fixes: https://github.com/nodejs/node/issues/8379
PR-URL: https://github.com/nodejs/node/pull/8391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

9 years ago

3 Commits (49c5ff4408eaf51338fe0724792f500fcd34ea37)