lukechilds/node - node - Gitea: Git with a cup of tea

16887 Commits

131 Branches

446 Tags

325 MiB

Tree: 4a5a9445b5

Commit Graph

Author	SHA1	Message	Date
cjihrig	5587ff1ccd	dns: handle implicit bind DNS errors When send() triggers an implicit bind, the send operation is added to an internal queue. If a DNS error occurs during the bind, there is currently no mechanism for clearing the queue other than sending more data. If DNS errors keep occurring, the queue will continue to grow with no upper bound. This commit reports errors with implicit binds, and clears the queue. This should be fine, given the nature of UDP. Refs: https://github.com/nodejs/node-v0.x-archive/pull/8705 Refs: https://github.com/nodejs/node/pull/10902 PR-URL: https://github.com/nodejs/node/pull/11036 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

cjihrig

5587ff1ccd

dns: handle implicit bind DNS errors

When send() triggers an implicit bind, the send operation is
added to an internal queue. If a DNS error occurs during the bind,
there is currently no mechanism for clearing the queue other than
sending more data. If DNS errors keep occurring, the queue will
continue to grow with no upper bound. This commit reports errors
with implicit binds, and clears the queue. This should be fine,
given the nature of UDP.

Refs: https://github.com/nodejs/node-v0.x-archive/pull/8705
Refs: https://github.com/nodejs/node/pull/10902
PR-URL: https://github.com/nodejs/node/pull/11036
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

1 Commits (4a5a9445b542333ac7cd8e3ea39ac784a16ccd97)