lukechilds/node - node - Gitea: Git with a cup of tea

16887 Commits

131 Branches

446 Tags

325 MiB

Tree: 4a5a9445b5

Commit Graph

Author	SHA1	Message	Date
Christopher Hiller	32679c73c1	dgram: improve signature of Socket.prototype.send - Do not require presence of `address` parameter to use `callback` parameter; `address` is always optional - Improve exception messaging if `address` is invalid type - If `address` is an invalid type, guarantee a synchronously thrown exception - Update documentation to reflect signature changes - Add coverage around valid, undocumented types for `address` parameter. - Add coverage around known invalid, but uncovered, types for `address` parameter. PR-URL: https://github.com/nodejs/node/pull/10473 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago

Author

SHA1

Message

Date

Christopher Hiller

32679c73c1

dgram: improve signature of Socket.prototype.send

- Do not require presence of `address` parameter to use `callback`
  parameter; `address` is *always* optional
- Improve exception messaging if `address` is invalid type
- If `address` is an invalid type, guarantee a synchronously thrown
  exception
- Update documentation to reflect signature changes
- Add coverage around valid, undocumented types for `address` parameter.
- Add coverage around known invalid, but uncovered, types for `address`
  parameter.

PR-URL: https://github.com/nodejs/node/pull/10473
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

1 Commits (4a5a9445b542333ac7cd8e3ea39ac784a16ccd97)