lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Nathan Jiang	01eddd97f7	test: replace string concatenation with template PR-URL: https://github.com/nodejs/node/pull/14342 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>	8 years ago
Vse Mozhet Byt	2d2986ae72	test: simplify test skipping * Make common.skip() exit. Also add common.printSkipMessage() for partial skips. * Don't make needless things before skip PR-URL: https://github.com/nodejs/node/pull/14021 Fixes: https://github.com/nodejs/node/issues/14016 Reviewed-By: Refael Ackermann <refack@gmail.com>	8 years ago
Tobias Nießen	a1ecdcfb15	test: fix failure in test-icu-data-dir.js This fixes a broken test on Windows caused by EOL conversion. PR-URL: https://github.com/nodejs/node/pull/13987 Refs: https://github.com/nodejs/node/pull/13940 Refs: https://github.com/nodejs/node/issues/13986 Reviewed-By: Refael Ackermann <refack@gmail.com>	8 years ago
Timothy Gu	9330835754	src: add missing new line to printed message PR-URL: https://github.com/nodejs/node/pull/13940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>	8 years ago
Daniel Bevenius	a8979a6054	test: add hasIntl to failing test Currently when node is configured --without-intl the tests in this commit fail. This commit adds checks for internationalization for these tests PR-URL: https://github.com/nodejs/node/pull/13699 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Ben Noordhuis	46e773c5db	src: check if --icu-data-dir= points to valid dir Call uc_init() after u_setDataDirectory() to find out if the data directory is actually valid. This commit removes parallel/test-intl-no-icu-data, added in commit `46345b9` ("src: make --icu-data-dir= switch testable"). It no longer works now that an invalid --icu-data-dir= argument is rejected. Coverage is now provided by parallel/test-icu-data-dir. Fixes: https://github.com/nodejs/node/issues/13043 Refs: https://github.com/nodejs/node-gyp/issues/1199 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>	8 years ago