lukechilds/node - node - Gitea: Git with a cup of tea

14417 Commits

131 Branches

446 Tags

325 MiB

Tree: 4bb61553f0

Commit Graph

Author	SHA1	Message	Date
Rich Trott	924ea0a2bd	test: fix flaky test-http-server-consumed-timeout Using identical timeout values appears to have eliminated the flakiness in the test. Fixes: https://github.com/nodejs/node/issues/7643 PR-URL: https://github.com/nodejs/node/pull/7717 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>	9 years ago
Brian White	9a8acad6ff	test: use random ports where possible This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago
Fedor Indutny	9a8b53124d	http: unref socket timer on parser execute When underlying `net.Socket` instance is consumed in http server - no `data` events are emitted, and thus `socket.setTimeout` fires the callback even if the data is constantly flowing into the socket. Fix this by calling `socket._unrefTimer()` on every `onParserExecute` call. Fix: #5899 PR-URL: https://github.com/nodejs/node/pull/6286 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago

Author

SHA1

Message

Date

Rich Trott

924ea0a2bd

test: fix flaky test-http-server-consumed-timeout

Using identical timeout values appears to have eliminated the flakiness
in the test.

Fixes: https://github.com/nodejs/node/issues/7643
PR-URL: https://github.com/nodejs/node/pull/7717
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

9 years ago

Brian White

9a8acad6ff

test: use random ports where possible

This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.

PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

9 years ago

Fedor Indutny

9a8b53124d

http: unref socket timer on parser execute

When underlying `net.Socket` instance is consumed in http server - no
`data` events are emitted, and thus `socket.setTimeout` fires the
callback even if the data is constantly flowing into the socket.

Fix this by calling `socket._unrefTimer()` on every `onParserExecute`
call.

Fix: #5899
PR-URL: https://github.com/nodejs/node/pull/6286
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

3 Commits (4bb61553f00740efdfa1f133cceb84f7aad286c4)