lukechilds/node - node - Gitea: Git with a cup of tea

13384 Commits

131 Branches

446 Tags

325 MiB

Tree: 4e38655d5f

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Jeremiah Senkpiel	4067cde7ee	test: abstract skip functionality to common The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of `52bae222a3` for v4.x Ref: https://github.com/nodejs/node/pull/6697 PR-URL: https://github.com/nodejs/node/pull/7114 Reviewed-By: Myles Borins <myles.borins@gmail.com>	9 years ago
Rich Trott	74eb632483	test: apply correct assert.fail() arguments The assert.fail function signature has the message as the third argument but, understandably, it is often assumed that it is the first argument (or at least the first argument if no other arguments are passed). This corrects the assert.fail() invocations in the Node.js tests. Before: assert.fail('message'); // result: AssertionError: 'message' undefined undefined After: assert.fail(null, null, 'message'); // result: AssertionError: message PR-URL: https://github.com/nodejs/node/pull/3378 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	10 years ago
Alexis Campailla	fa08d1d8a1	test: add test-spawn-cmd-named-pipe Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: https://github.com/nodejs/node-v0.x-archive/issues/7345 PR-URL: https://github.com/nodejs/node/pull/2770 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>	10 years ago

Jeremiah Senkpiel

4067cde7ee

test: abstract skip functionality to common

The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae222a3 for v4.x

Ref: https://github.com/nodejs/node/pull/6697
PR-URL: https://github.com/nodejs/node/pull/7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>

9 years ago

Rich Trott

74eb632483

test: apply correct assert.fail() arguments

The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).

This corrects the assert.fail() invocations in the Node.js tests.

Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined

After:
assert.fail(null, null, 'message');
// result: AssertionError: message

PR-URL: https://github.com/nodejs/node/pull/3378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

10 years ago

Alexis Campailla

fa08d1d8a1

test: add test-spawn-cmd-named-pipe

Adding a Windows test to verify that a node process spawned via
cmd with named pipes can access its stdio streams.

Ref: https://github.com/nodejs/node-v0.x-archive/issues/7345

PR-URL: https://github.com/nodejs/node/pull/2770
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>

10 years ago

3 Commits (4e38655d5fb1c9660e8321f53fcdf1a4e59a1ee9)