lukechilds/node - node - Gitea: Git with a cup of tea

18283 Commits

131 Branches

446 Tags

325 MiB

Tree: 4f0b107334

Commit Graph

Author	SHA1	Message	Date
Matteo Collina	107db33fb9	process: triggerAsyncId can be undefined Fixes: https://github.com/nodejs/node/issues/14386 Fixes: https://github.com/nodejs/node/issues/14381 PR-URL: https://github.com/nodejs/node/pull/14387 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>	8 years ago
Andreas Madsen	0fd4c73e5c	async_hooks: fix default nextTick triggerAsyncId In the case where triggerAsyncId is null it should default to the current executionAsyncId. This worked but as a side-effect the resource object was changed too. This fix also makes the null check more strict. EmitInitS is not a documented API, thus there is no reason to be flexible in its input. Ref: https://github.com/nodejs/node/issues/13548#issuecomment-310985270 PR-URL: https://github.com/nodejs/node/pull/14026 Reviewed-By: Refael Ackermann <refack@gmail.com>	8 years ago

Author

SHA1

Message

Date

Matteo Collina

107db33fb9

process: triggerAsyncId can be undefined

Fixes: https://github.com/nodejs/node/issues/14386
Fixes: https://github.com/nodejs/node/issues/14381

PR-URL: https://github.com/nodejs/node/pull/14387
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

8 years ago

Andreas Madsen

0fd4c73e5c

async_hooks: fix default nextTick triggerAsyncId

In the case where triggerAsyncId is null it should default to the
current executionAsyncId. This worked but as a side-effect the resource
object was changed too.

This fix also makes the null check more strict. EmitInitS is not a
documented API, thus there is no reason to be flexible in its input.

Ref: https://github.com/nodejs/node/issues/13548#issuecomment-310985270
PR-URL: https://github.com/nodejs/node/pull/14026
Reviewed-By: Refael Ackermann <refack@gmail.com>

8 years ago

2 Commits (4f0b10733483fbb62776b7973200e5fbb56349a9)