lukechilds/node - node - Gitea: Git with a cup of tea

12829 Commits

131 Branches

446 Tags

325 MiB

Tree: 4f87574764

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	8fd3ce100e	src: make base64 decoding 50% faster Make the inner loop execute fewer compare-and-branch executions per processed byte, resulting in a 50% or more speedup. This coincidentally fixes an out-of-bounds read: while (unbase64(src) < 0 && src < srcEnd) Should have read: while (src < srcEnd && unbase64(src) < 0) But this commit removes the offending code altogether. Fixes: https://github.com/nodejs/io.js/issues/2166 PR-URL: https://github.com/nodejs/io.js/pull/2193 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	10 years ago

Author

SHA1

Message

Date

Ben Noordhuis

8fd3ce100e

src: make base64 decoding 50% faster

Make the inner loop execute fewer compare-and-branch executions per
processed byte, resulting in a 50% or more speedup.

This coincidentally fixes an out-of-bounds read:

    while (unbase64(*src) < 0 && src < srcEnd)

Should have read:

    while (src < srcEnd && unbase64(*src) < 0)

But this commit removes the offending code altogether.

Fixes: https://github.com/nodejs/io.js/issues/2166
PR-URL: https://github.com/nodejs/io.js/pull/2193
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

10 years ago

1 Commits (4f875747645099a0127299cf38c149f85e764816)