test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.
PR-URL: https://github.com/nodejs/node/pull/10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* var -> const/let
* IIFE to blocks
PR-URL: https://github.com/nodejs/node/pull/10029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Updated regex for error assertion.
PR-URL: https://github.com/nodejs/node/pull/9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
assert.equal() -> assert.strictEqual()
PR-URL: https://github.com/nodejs/node/pull/9873
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
assert.equal() -> assert.strictEqual()
PR-URL: https://github.com/nodejs/node/pull/9911
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Use assert.strictEqual() instead of assert.equal().
PR-URL: https://github.com/nodejs/node/pull/9890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Switch assert.equal to assert.strictEqual.
PR-URL: https://github.com/nodejs/node/pull/10057
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Change all assert.equal() to use assert.strictEqual().
PR-URL: https://github.com/nodejs/node/pull/10060
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
* var -> const
* assert.equal -> assert.strictEqual
PR-URL: https://github.com/nodejs/node/pull/9907
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
* `var` to `const`
* use `assert.strictEqual`
PR-URL: https://github.com/nodejs/node/pull/9905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/9904
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace var with const and use strictEqual().
PR-URL: https://github.com/nodejs/node/pull/10062
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Updated test-cluster-send-deadlock.js to change
assert.equal to assert.strictEqual
PR-URL: https://github.com/nodejs/node/pull/9902
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
use common.fail instead of assert(false)
change var to let or const as appropriate
PR-URL: https://github.com/nodejs/node/pull/9900
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Update var to let/const and replace arbitrary timeout.
PR-URL: https://github.com/nodejs/node/pull/10064
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Use asssert.strictEqual to disallow coersion.
PR-URL: https://github.com/nodejs/node/pull/10071
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Changes assert.equal to assert.strictEqual to ensure specificity.
Changes var declarations to const/let where appropriate.
PR-URL: https://github.com/nodejs/node/pull/10074
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Refactored `test-tls-server-verify.js` to replace uses of `var` with
`const` and `let`. Also replaced uses of `assert.equal` with
`assert.strictEqual`.
PR-URL: https://github.com/nodejs/node/pull/10076
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
- Replaced var with const and let.
- Replaced assert.equal() with assert.strictEqual().
- Added error message checking for assert.throws().
PR-URL: https://github.com/nodejs/node/pull/9971
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Replaces var with const and adds common.mustCall().
PR-URL: https://github.com/nodejs/node/pull/9967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Replaced var with either const or let.
- Replaced assert.equal() with assert.strictEqual().
- Replaced all error checks with assert.ifError(e).
PR-URL: https://github.com/nodejs/node/pull/10110
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
changes assert.equal to assert.strictEqual to ensure specificity
PR-URL: https://github.com/nodejs/node/pull/10067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws
PR-URL: https://github.com/nodejs/node/pull/9906
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/9897
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Changed all references from assert.Equal() to assert.strictEqual().
PR-URL: https://github.com/nodejs/node/pull/10077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
* convert assert.equal to assert.strictEqual
* convert var to const/let
PR-URL: https://github.com/nodejs/node/pull/9894
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
assert.equal() -> assert.strictEqual()
PR-URL: https://github.com/nodejs/node/pull/9893
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/9892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Use const over var.
Assert error message with regex.
PR-URL: https://github.com/nodejs/node/pull/9891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Change instances of var with const/let.
Change assert.equal to assert.strictEqual.
PR-URL: https://github.com/nodejs/node/pull/9888
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test
PR-URL: https://github.com/nodejs/node/pull/9886
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Replace assert.equal with assert.strictEqual
PR-URL: https://github.com/nodejs/node/pull/9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
this change is part of code and learn (NINA-2016)
PR-URL: https://github.com/nodejs/node/pull/9877
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* Use `common.mustCall` for all callbacks
* Use `const` instead of `var`
PR-URL: https://github.com/nodejs/node/pull/9876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/9874
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Change var to const.
PR-URL: https://github.com/nodejs/node/pull/10055
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Replaces the use of assert.equal() with assert.strictEqual in test
code.
PR-URL: https://github.com/nodejs/node/pull/9935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use const instead of var for assignments.
PR-URL: https://github.com/nodejs/node/pull/9951
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove console statements and prefer strictEqual() over equal()
in assertions.
PR-URL: https://github.com/nodejs/node/pull/9887
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make change in test file from var to const/let.
PR-URL: https://github.com/nodejs/node/pull/10018
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
- updated vars to const
- add common.mustCall() to setup callback
PR-URL: https://github.com/nodejs/node/pull/9960
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Raja Panidepu
michael6
Oscar Martinez
Matt Crummey
Josh Mays
Konstantin Likhter
Johnny Reading
Exlipse7
k3kathy
Cesar Hernandez
Sean Villars
anoff
Sarah Meyer
Outsider
Daniel Pittman
Jay Brownlee
Chris Bystrek
Kent.Fan
davidmarkclements
Hutson Betts
Richard Karmazin
Adrian Estrada
adelmann
Julian Duque
Hitesh Kanwathirtha
bjdelro
JDHarmon
Jonathan Darling
Wes Tyler
Harish Tejwani
Daniel Flores
Peter Masucci
rajatk
Devon Rifkin
Matt Webb
Matt Wilson
Mitchell Stoutin
stokingerl
David Bradford
Aileen
Christine Hong