lukechilds/node - node - Gitea: Git with a cup of tea

383 Commits

131 Branches

446 Tags

325 MiB

Tree: 56c785ceae

Commit Graph

Author	SHA1	Message	Date
Ryan	1b6bbc619d	Bugfix: Server-side clients not attached between creation and on_connect. Solution is to manually add Attach() to OnConnection. For client side it seems there is no Detach() being called after NS resolution? Otherwise I would have removed it. That was another bug. Note: We don't want to modify evnet's behavior to have on_connect called directly when the socket is accepted. evnet needs to support SSL, and on_connect is supposed to signal that the SSL connection is established. The point here is that being "connected" and being "attached" to the event loop are two different things. SSL stuff may be transmitted when a socket is not "connected" but it must always be attached.	16 years ago

Author

SHA1

Message

Date

Ryan

1b6bbc619d

Bugfix: Server-side clients not attached between creation and on_connect.

Solution is to manually add Attach() to OnConnection.

For client side it seems there is no Detach() being called after NS
resolution? Otherwise I would have removed it. That was another bug.

Note: We don't want to modify evnet's behavior to have on_connect called
directly when the socket is accepted. evnet needs to support SSL, and
on_connect is supposed to signal that the SSL connection is established. The
point here is that being "connected" and being "attached" to the event loop
are two different things. SSL stuff may be transmitted when a socket is not
"connected" but it must always be attached.

16 years ago

1 Commits (56c785ceae84a34f4e0a414032f1d4c6f5d8a5b5)