lukechilds/node - node - Gitea: Git with a cup of tea

16334 Commits

131 Branches

446 Tags

325 MiB

Tree: 5703d22849

Commit Graph

Author	SHA1	Message	Date
Ben Noordhuis	0383048b76	test: fix coverity UNINIT_CTOR cctest warning Explicitly initialize `platform_` to nullptr. Coverity cannot divine it is set and cleared by the Setup() and TearDown() methods. PR-URL: https://github.com/nodejs/node/pull/12387 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Daniel Bevenius	3bb117e310	build: enable cctest to use generated objects This commit tries to make it simpler to add unit tests (cctest) for code that needs to test node core funtionality but that might not be appropriate as an addon or a JavaScript test. An example of this could be adding functionality targeted for situations when Node itself is embedded. Currently it was not as easy, or efficient, as one would have hoped to add such tests. The object output directories vary for different operating systems which we need to link to so that we don't have an additional compilation step. PR-URL: https://github.com/nodejs/node/pull/11956 Backport-PR-URL: https://github.com/nodejs/node/pull/12948 Ref: https://github.com/nodejs/node/pull/9163 Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

Ben Noordhuis

0383048b76

test: fix coverity UNINIT_CTOR cctest warning

Explicitly initialize `platform_` to nullptr.  Coverity cannot divine
it is set and cleared by the Setup() and TearDown() methods.

PR-URL: https://github.com/nodejs/node/pull/12387
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Daniel Bevenius

3bb117e310

build: enable cctest to use generated objects

This commit tries to make it simpler to add unit tests (cctest) for
code that needs to test node core funtionality but that might not be
appropriate as an addon or a JavaScript test. An example of this could
be adding functionality targeted for situations when Node itself is
embedded.

Currently it was not as easy, or efficient, as one would have hoped to
add such tests. The object output directories vary for different
operating systems which we need to link to so that we don't have an
additional compilation step.

PR-URL: https://github.com/nodejs/node/pull/11956
Backport-PR-URL: https://github.com/nodejs/node/pull/12948
Ref: https://github.com/nodejs/node/pull/9163
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

2 Commits (5703d22849ac34240655ec35edb044e4b4d25ca0)