lukechilds/node - node - Gitea: Git with a cup of tea

16334 Commits

131 Branches

446 Tags

325 MiB

Tree: 5703d22849

Commit Graph

Author	SHA1	Message	Date
Sakthipriyan Vairamani (thefourtheye)	4caae6924f	test: reduce buffer size in buffer-creation test This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: https://github.com/nodejs/node/pull/11177 Ref: https://github.com/nodejs/node/issues/10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago
Rich Trott	1b85989fb2	test: move long-running test to sequential test-buffer-creation-regression is flaky on some SmartOS hosts in CI, timing out. Move to sequential so it does not compete with other tests for resources. Reduce three test cases to just the one needed to identify the regression. PR-URL: https://github.com/nodejs/node/pull/10161 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Backport-Of: https://github.com/nodejs/node/pull/10161 PR-URL: https://github.com/nodejs/node/pull/11176 Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

Sakthipriyan Vairamani (thefourtheye)

4caae6924f

test: reduce buffer size in buffer-creation test

This test is allocating much more memory than necessary to actually
reproduce the original problem. Lowering the amount of memory allocated
increases performance at least in some cases and makes this test less
likely to time out on SmartOS.

PR-URL: https://github.com/nodejs/node/pull/11177
Ref: https://github.com/nodejs/node/issues/10166

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

Rich Trott

1b85989fb2

test: move long-running test to sequential

test-buffer-creation-regression is flaky on some SmartOS hosts in CI,
  timing out. Move to sequential so it does not compete with other tests
  for resources. Reduce three test cases to just the one needed to
  identify the regression.

  PR-URL: https://github.com/nodejs/node/pull/10161
  Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  Reviewed-By: Italo A. Casas <me@italoacasas.com>

Backport-Of: https://github.com/nodejs/node/pull/10161
PR-URL: https://github.com/nodejs/node/pull/11176
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

2 Commits (5703d22849ac34240655ec35edb044e4b4d25ca0)