lukechilds/node - node - Gitea: Git with a cup of tea

14546 Commits

131 Branches

446 Tags

325 MiB

Tree: 57312fc0c5

Commit Graph

Author	SHA1	Message	Date
Rich Trott	8b43d3f52d	zlib: do not emit event on *Sync() methods Asynchronous functions in `zlib` should not emit the close event. This fixes an issue where asynchronous calls in a for loop could exhaust memory because the pending event prevents the objects from being garbage collected. Fixes: https://github.com/nodejs/node/issues/1668 PR-URL: https://github.com/nodejs/node/pull/5707 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>	9 years ago

Author

SHA1

Message

Date

Rich Trott

8b43d3f52d

zlib: do not emit event on *Sync() methods

Asynchronous functions in `zlib` should not emit the close event.

This fixes an issue where asynchronous calls in a for loop could exhaust
memory because the pending event prevents the objects from being garbage
collected.

Fixes: https://github.com/nodejs/node/issues/1668
PR-URL: https://github.com/nodejs/node/pull/5707
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

9 years ago

1 Commits (57312fc0c55c8b850acdcbed3a87bd23ddc4e59b)