lukechilds/node - node - Gitea: Git with a cup of tea

12875 Commits

131 Branches

446 Tags

325 MiB

Tree: 5a2445b0c0

Commit Graph

Author	SHA1	Message	Date
Rich Trott	abe8a344a5	test: remove unused variables form http tests The http tests seem especially prone to including unused variables. This change removes them. PR-URL: https://github.com/nodejs/node/pull/4422 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	9 years ago
Fedor Indutny	7ec0491fd0	http_server: fix resume after socket close Socket resume may happen on a next tick, and in following scenario: 1. `socket.resume()` 2. `socket._handle.close()` 3. `socket._handle = null;` The `_resume` will be invoked with empty `._handle` property. There is nothing bad about it, and we should just ignore the `resume`/`pause` events in this case. Same applies to the unconsuming of socket on adding `data` and/or `readable` event listeners. Fix: https://github.com/nodejs/node/issues/2821 PR-URL: https://github.com/nodejs/node/pull/2824 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	10 years ago

Author

SHA1

Message

Date

Rich Trott

abe8a344a5

test: remove unused variables form http tests

The http tests seem especially prone to including unused variables.
This change removes them.

PR-URL: https://github.com/nodejs/node/pull/4422
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

9 years ago

Fedor Indutny

7ec0491fd0

http_server: fix resume after socket close

Socket resume may happen on a next tick, and in following scenario:

1. `socket.resume()`
2. `socket._handle.close()`
3. `socket._handle = null;`

The `_resume` will be invoked with empty `._handle` property. There is
nothing bad about it, and we should just ignore the `resume`/`pause`
events in this case.

Same applies to the unconsuming of socket on adding `data` and/or
`readable` event listeners.

Fix: https://github.com/nodejs/node/issues/2821

PR-URL: https://github.com/nodejs/node/pull/2824
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

10 years ago

2 Commits (5a2445b0c06b79361b39cef3728a3f781790fbd9)