lukechilds/node - node - Gitea: Git with a cup of tea

12875 Commits

131 Branches

446 Tags

325 MiB

Tree: 5a2445b0c0

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Ben Noordhuis	213ede6cee	repl: fix require('3rdparty') regression Fix module loading of third-party modules in the REPL by inheriting module.paths from the REPL's parent module. Commit `ee72ee7` ("module,repl: remove repl require() hack") introduced a regression where require() of modules in node_modules directories no longer worked in the REPL (and fortunately only in the REPL.) It turns out we didn't have test coverage for that but we do now. Fixes: https://github.com/nodejs/node/issues/4208 PR-URL: https://github.com/nodejs/node/pull/4215 Reviewed-By: Roman Reiss <me@silverwind.io>	9 years ago

Ben Noordhuis

213ede6cee

repl: fix require('3rdparty') regression

Fix module loading of third-party modules in the REPL by inheriting
module.paths from the REPL's parent module.

Commit ee72ee7 ("module,repl: remove repl require() hack") introduced
a regression where require() of modules in node_modules directories
no longer worked in the REPL (and fortunately only in the REPL.)
It turns out we didn't have test coverage for that but we do now.

Fixes: https://github.com/nodejs/node/issues/4208
PR-URL: https://github.com/nodejs/node/pull/4215
Reviewed-By: Roman Reiss <me@silverwind.io>

9 years ago

1 Commits (5a2445b0c06b79361b39cef3728a3f781790fbd9)