lukechilds/node - node - Gitea: Git with a cup of tea

13746 Commits

131 Branches

446 Tags

325 MiB

Tree: 5eb4ec090d

Commit Graph

Author	SHA1	Message	Date
Matteo Collina	8af4bb86c0	dgram: default send address to 127.0.0.1 or ::1 In net we default to 'localhost' as the default address for connect. Not doing the same on dgram is confusing, because sending to 0.0.0.0 works on Linux/OS X but not on Windows. Defaulting that to 127.0.0.1 / ::1 addresses that. Related: https://github.com/nodejs/node/pull/5407 Related: https://github.com/nodejs/node/issues/5398 Fixes: https://github.com/nodejs/node/issues/5487 PR-URL: https://github.com/nodejs/node/pull/5493 Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	9 years ago
Matteo Collina	725ffdb9b7	dgram: handle default address case when offset and length are specified Fixes a regression introduced by: https://github.com/nodejs/node/pull/4374. Adds a new test to avoid similar issue in the future. The test is disabled on windows, because this feature never worked there. Fixes: https://github.com/nodejs/node/issues/5398 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Evan Lucas <evanlucas@me.com>	9 years ago

Author

SHA1

Message

Date

Matteo Collina

8af4bb86c0

dgram: default send address to 127.0.0.1 or ::1

In net we default to 'localhost' as the default address for connect.
Not doing the same on dgram is confusing, because sending to 0.0.0.0
works on Linux/OS X but not on Windows. Defaulting that to 127.0.0.1 /
::1 addresses that.

Related: https://github.com/nodejs/node/pull/5407
Related: https://github.com/nodejs/node/issues/5398
Fixes: https://github.com/nodejs/node/issues/5487
PR-URL: https://github.com/nodejs/node/pull/5493
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

9 years ago

Matteo Collina

725ffdb9b7

dgram: handle default address case when offset and length are specified

Fixes a regression introduced by: https://github.com/nodejs/node/pull/4374.
Adds a new test to avoid similar issue in the future.
The test is disabled on windows, because this feature never worked
there.

Fixes: https://github.com/nodejs/node/issues/5398
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Evan Lucas <evanlucas@me.com>

9 years ago

1 Commits (5eb4ec090d70a848e2ae98bd526634bf9d1bf08c)