lukechilds/node - node - Gitea: Git with a cup of tea

16397 Commits

131 Branches

446 Tags

325 MiB

Tree: 6285ff2275

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Ben Noordhuis	a8613f8ce4	src: fix --icu-data-dir= regression Commit `a8734af` ("src: make copies of startup environment variables") from two weeks ago introduced a regression in the capturing of the `--icu-data-dir=` switch: it captured the string up to the `=` instead of what comes after it. PR-URL: https://github.com/nodejs/node/pull/11255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago
Ben Noordhuis	73e316e908	src: make --icu-data-dir= switch testable Move some code around so we can properly test whether the switch actually does anything. PR-URL: https://github.com/nodejs/node/pull/11255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago

Ben Noordhuis

a8613f8ce4

src: fix --icu-data-dir= regression

Commit a8734af ("src: make copies of startup environment variables")
from two weeks ago introduced a regression in the capturing of the
`--icu-data-dir=` switch: it captured the string up to the `=` instead
of what comes after it.

PR-URL: https://github.com/nodejs/node/pull/11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

8 years ago

Ben Noordhuis

73e316e908

src: make --icu-data-dir= switch testable

Move some code around so we can properly test whether the switch
actually does anything.

PR-URL: https://github.com/nodejs/node/pull/11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

8 years ago

2 Commits (6285ff2275cbe237d3eafa26c5c02671b1de386e)