lukechilds/node - node - Gitea: Git with a cup of tea

18514 Commits

131 Branches

446 Tags

325 MiB

Tree: 64162a1041

Commit Graph

Author	SHA1	Message	Date
Vse Mozhet Byt	50b35460e3	test: fix nits in test-fs-mkdir-rmdir.js * Add common.mustCall(). * Add check for error existence, not only for error details. * Use test(), not match() in a boolean context. * Properly reverse meanings of assert messages. PR-URL: https://github.com/nodejs/node/pull/13680 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>	8 years ago
Gibson Fahnestock	3d2aef3979	test: s/assert.equal/assert.strictEqual/ Use assert.strictEqual instead of assert.equal in tests, manually convert types where necessary. PR-URL: https://github.com/nodejs/node/pull/10698 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>	8 years ago
Sakthipriyan Vairamani	571a517259	test: test sync version of mkdir & rmdir This patch includes tests for sync versions of mkdir and rmdir. Also, it moves the test to `parallel`. PR-URL: https://github.com/nodejs/node/pull/2588 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	10 years ago

Author

SHA1

Message

Date

Vse Mozhet Byt

50b35460e3

test: fix nits in test-fs-mkdir-rmdir.js

* Add common.mustCall().
* Add check for error existence, not only for error details.
* Use test(), not match() in a boolean context.
* Properly reverse meanings of assert messages.

PR-URL: https://github.com/nodejs/node/pull/13680
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

8 years ago

Gibson Fahnestock

3d2aef3979

test: s/assert.equal/assert.strictEqual/

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>

8 years ago

Sakthipriyan Vairamani

571a517259

test: test sync version of mkdir & rmdir

This patch includes tests for sync versions of mkdir and rmdir.
Also, it moves the test to `parallel`.

PR-URL: https://github.com/nodejs/node/pull/2588
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

10 years ago

3 Commits (64162a1041f293bfafb7bc8d030a83e5ab5e8b69)