lukechilds/node - node - Gitea: Git with a cup of tea

15537 Commits

131 Branches

446 Tags

325 MiB

Tree: 6502427761

Commit Graph

Author	SHA1	Message	Date
Michaël Zasso	29da8cf8d7	util: make inherits work with classes The current implementation overwrites the prototype of the target constructor. It is not allowed with ES2015 classes because the prototype property is read only. Use Object.setPrototypeOf instead. Fixes: https://github.com/nodejs/node/issues/3452 PR-URL: https://github.com/nodejs/node/pull/3455 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Michaël Zasso	df738ac56c	test: improve tests for util.inherits inherits is used in lib and tests but its functionality itself is not tested yet. PR-URL: https://github.com/nodejs/node/pull/3507 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>	9 years ago

Author

SHA1

Message

Date

Michaël Zasso

29da8cf8d7

util: make inherits work with classes

The current implementation overwrites the prototype of the target
constructor. It is not allowed with ES2015 classes because the prototype
property is read only. Use Object.setPrototypeOf instead.

Fixes: https://github.com/nodejs/node/issues/3452
PR-URL: https://github.com/nodejs/node/pull/3455
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

Michaël Zasso

df738ac56c

test: improve tests for util.inherits

inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: https://github.com/nodejs/node/pull/3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

9 years ago

2 Commits (6502427761801ef34d77a67aa0efd899f9c58488)