lukechilds/node - node - Gitea: Git with a cup of tea

15117 Commits

131 Branches

446 Tags

325 MiB

Tree: 653f092639

Commit Graph

Author	SHA1	Message	Date
Rich Trott	082cc8d6d8	test: remove unnecessary assignments common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. PR-URL: https://github.com/nodejs/node/pull/4408 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Trevor Norris	178ac3367f	js_stream: prevent abort if isalive doesn't exist Attempting to check IsAlive() on a JSStream before the isAlive() callback can be set in JS causes a CHECK to fail in MakeCallback. Instead return false if the callback hasn't been set. PR-URL: https://github.com/nodejs/node/pull/3282 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>	10 years ago

Author

SHA1

Message

Date

Rich Trott

082cc8d6d8

test: remove unnecessary assignments

common.js needs to be loaded in all tests so that there is checking
for variable leaks and possibly other things. However, it does not
need to be assigned to a variable if nothing in common.js is referred
to elsewhere in the test.

PR-URL: https://github.com/nodejs/node/pull/4408
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

Trevor Norris

178ac3367f

js_stream: prevent abort if isalive doesn't exist

Attempting to check IsAlive() on a JSStream before the isAlive()
callback can be set in JS causes a CHECK to fail in MakeCallback.
Instead return false if the callback hasn't been set.

PR-URL: https://github.com/nodejs/node/pull/3282
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

10 years ago

2 Commits (653f092639e7aca9757982328af0ad9e07b1cd2e)