lukechilds/node - node - Gitea: Git with a cup of tea

17429 Commits

131 Branches

446 Tags

325 MiB

Tree: 654afa2c19

Commit Graph

Author	SHA1	Message	Date
Rich Trott	a10e657657	test: fix flaky child-process-exec-kill-throws This is a fix for test-child-process-exec-kill-throws which is currently flaky on Windows. A bug in the test was causing the child process to fail for reasons other than those intended by the test. Instead of failing for exceeding the `maxBuffer` setting, the test was failing because it was trying to load `internal/child_process` without being passed the `expose-internals` flag. Move that module to where only the parent process (which gets the flag) loads it. Additionally, improve an assertion message to help debug problems like this. PR-URL: https://github.com/nodejs/node/pull/12111 Fixes: https://github.com/nodejs/node/issues/12053 Reviewed-By: Richard Lau <riclau@uk.ibm.com>	8 years ago
cjihrig	9ac363b5d6	test: cover thrown errors from exec() kill This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception. PR-URL: https://github.com/nodejs/node/pull/11038 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	8 years ago

Author

SHA1

Message

Date

Rich Trott

a10e657657

test: fix flaky child-process-exec-kill-throws

This is a fix for test-child-process-exec-kill-throws which is currently
flaky on Windows.

A bug in the test was causing the child process to fail for reasons
other than those intended by the test. Instead of failing for exceeding
the `maxBuffer` setting, the test was failing because it was trying to
load `internal/child_process` without being passed the
`expose-internals` flag. Move that module to where only the parent
process (which gets the flag) loads it.

Additionally, improve an assertion message to help debug problems like
this.

PR-URL: https://github.com/nodejs/node/pull/12111
Fixes: https://github.com/nodejs/node/issues/12053
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

8 years ago

cjihrig

9ac363b5d6

test: cover thrown errors from exec() kill

This commit adds code coverage for the scenario where exec()
kills a child process, but the call to ChildProcess#kill()
throws an exception.

PR-URL: https://github.com/nodejs/node/pull/11038
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

8 years ago

2 Commits (654afa2c195a68ce4959fe7f918d70da99d7ba05)