lukechilds/node - node - Gitea: Git with a cup of tea

9917 Commits

131 Branches

446 Tags

325 MiB

Tree: 6569812531

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Alexis Campailla	edfc0d9ffe	test: debug-signal-cluster increase timeouts The test needs a little more time to run so that it passes for all builds (eg: Windows, debug)	11 years ago
Ben Noordhuis	ca363cf1ae	debugger: make busy loops SIGUSR1-interruptible Commit `30e5366b` ("core: Use a uv_signal for debug listener") changed SIGUSR1 handling from a signal handler to libuv's uv_signal_*() functionality to fix a race condition (and possible hang) in the signal handler. While a good change in itself, it made it impossible to interrupt long running scripts. When a script is stuck in a busy loop, control never returns to the event loop, which in turn means the signal callback - and therefore the debugger - is never invoked. This commit changes SIGUSR1 handling back to a normal signal handler but one that treads _very_ carefully.	11 years ago
Miroslav Bajtoš	43ec1b1c2e	debugger, cluster: each worker has new debug port Implement support for debugging cluster workers. Each worker process is assigned a new debug port in an increasing sequence. I.e. when master process uses port 5858, then worker 1 uses port 5859, worker 2 uses port 5860, and so on. Introduce new command-line parameter '--debug-port=' which sets debug_port but does not start debugger. This option works for all node processes, it is not specific to cluster workers. Fixes joyent/node#5318.	12 years ago

Alexis Campailla

edfc0d9ffe

test: debug-signal-cluster increase timeouts

The test needs a little more time to run so that it passes for all
builds (eg: Windows, debug)

11 years ago

Ben Noordhuis

ca363cf1ae

debugger: make busy loops SIGUSR1-interruptible

Commit 30e5366b ("core: Use a uv_signal for debug listener") changed
SIGUSR1 handling from a signal handler to libuv's uv_signal_*()
functionality to fix a race condition (and possible hang) in the
signal handler.

While a good change in itself, it made it impossible to interrupt
long running scripts.  When a script is stuck in a busy loop, control
never returns to the event loop, which in turn means the signal
callback - and therefore the debugger - is never invoked.

This commit changes SIGUSR1 handling back to a normal signal handler
but one that treads _very_ carefully.

11 years ago

Miroslav Bajtoš

43ec1b1c2e

debugger, cluster: each worker has new debug port

Implement support for debugging cluster workers. Each worker process
is assigned a new debug port in an increasing sequence.

I.e. when master process uses port 5858, then worker 1 uses port 5859,
worker 2 uses port 5860, and so on.

Introduce new command-line parameter '--debug-port=' which sets debug_port
but does not start debugger. This option works for all node processes, it
is not specific to cluster workers.

Fixes joyent/node#5318.

12 years ago

3 Commits (6569812531758c5ef63e5e8091edd77ef5ebb325)