lukechilds/node - node - Gitea: Git with a cup of tea

10579 Commits

131 Branches

446 Tags

325 MiB

Tree: 66b243dd87

Commit Graph

Author	SHA1	Message	Date
Gireesh Punathil	f3f4e28216	test: make cluster tests more time tolerant simple tests test-cluster-master-error.js, test-cluster-master-kill.js fails in AIX with assertion failure indicating that the workers were alive even after the master terminated. A 200ms leeway is provided for the workers to actually terminate, but the isAlive check returns true in both the cases. In AIX, the workers were actually terminating, but they took more time - as much as 800ms (normal) to 1000ms (in rare cases). Based on a C test we ran, it is found that the exit routines in AIX is a bit more longer than that in Linux. There are a number of cleanup activities performed in exit() system call, and depending on when the signal handlers are shutdown in that sequence, the process will be deemed as dead or alive, from another process's perspective. process.kill(pid) is used in the test case to check the liveliness of the worker, and when the kill() call is issued, even if the target process is in it's exit sequences, if the signal handlers are not shut down, it will respond to external signals, causing those calls to pass. This fix extends the additional timeout for all platforms Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/joyent/node/pull/9431	10 years ago
Andreas Madsen	94d337eb0f	cluster: kill workers when master dies This patch will kill the worker once it has lost its connection with the parent. However if the worker are doing a suicide, other measures will be used.	13 years ago

Author

SHA1

Message

Date

Gireesh Punathil

f3f4e28216

test: make cluster tests more time tolerant

simple tests test-cluster-master-error.js, test-cluster-master-kill.js
fails in AIX with assertion failure indicating that the workers were
alive even after the master terminated. A 200ms leeway is provided for
the workers to actually terminate, but the isAlive check returns
true in both the cases.

In AIX, the workers were actually terminating, but they took more time
- as much as 800ms (normal) to 1000ms (in rare cases).

Based on a C test we ran, it is found that the exit routines in AIX
is a bit more longer than that in Linux. There are a number of cleanup
activities performed in exit() system call, and depending on when the
signal handlers are shutdown in that sequence, the process will be
deemed as dead or alive, from another process's perspective.

process.kill(pid) is used in the test case to check the liveliness of
the worker, and when the kill() call is issued, even if the target
process is in it's exit sequences, if the signal handlers are not shut
down, it will respond to external signals, causing those calls to pass.

This fix extends the additional timeout for all platforms

Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: https://github.com/joyent/node/pull/9431

10 years ago

Andreas Madsen

94d337eb0f

cluster: kill workers when master dies

This patch will kill the worker once it has lost its connection with the parent.
However if the worker are doing a suicide, other measures will be used.

13 years ago

2 Commits (66b243dd87509a7e259bf9bfec1ab31e01620b3e)