lukechilds/node - node - Gitea: Git with a cup of tea

10579 Commits

131 Branches

446 Tags

325 MiB

Tree: 66b243dd87

Commit Graph

Author	SHA1	Message	Date
Jackson Tian	4823afcbe2	fs: make F_OK/R_OK/W_OK/X_OK not writable Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect exception. Make these properties readonly. PR-URL: https://github.com/joyent/node/pull/9060 [trev.norris@gmail.com test properties are read only] Signed-off-by: Trevor Norris <trev.norris@gmail.com>	10 years ago
Julien Gilli	28d0cbbdfd	test: fix test-fs-access.js On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...) is expected to fail, but always succeeds if node runs as the super user, which is often the case for tests running on our continuous integration platform. This change makes the test try to change its process user id to nobody on non-windows platforms so that the above mentioned test can pass and still perform the actual desired test. If changing the process user id to a nobody is not possible, then the test checks that fs.access(readOnlyFile, W_OK, ...) actually succeeds. Fixes #9033. Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>	10 years ago
Colin Ihrig	29449349da	fs: add access() and accessSync() fs.exists() and fs.existsSync() do not follow the typical error first callback convention. access() and accessSync() are added as alternatives in this commit. PR-URL: https://github.com/joyent/node/pull/8714 Reviewed-by: Trevor Norris <trev.norris@gmail.com>	10 years ago

Author

SHA1

Message

Date

Jackson Tian

4823afcbe2

fs: make F_OK/R_OK/W_OK/X_OK not writable

Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect
exception. Make these properties readonly.

PR-URL: https://github.com/joyent/node/pull/9060
[trev.norris@gmail.com test properties are read only]
Signed-off-by: Trevor Norris <trev.norris@gmail.com>

10 years ago

Julien Gilli

28d0cbbdfd

test: fix test-fs-access.js

On non-windows supported platforms, fs.access(readOnlyFile, W_OK, ...)
is expected to fail, but always succeeds if node runs as the super user,
which is often the case for tests running on our continuous integration
platform.

This change makes the test try to change its process user id to nobody
on non-windows platforms so that the above mentioned test can pass and
still perform the actual desired test. If changing the process user id
to a nobody is not possible, then the test checks that
fs.access(readOnlyFile, W_OK, ...) actually succeeds.

Fixes #9033.

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>

10 years ago

Colin Ihrig

29449349da

fs: add access() and accessSync()

fs.exists() and fs.existsSync() do not follow the typical error first
callback convention. access() and accessSync() are added as alternatives
in this commit.

PR-URL: https://github.com/joyent/node/pull/8714
Reviewed-by: Trevor Norris <trev.norris@gmail.com>

10 years ago

3 Commits (66b243dd87509a7e259bf9bfec1ab31e01620b3e)