lukechilds/node - node - Gitea: Git with a cup of tea

10579 Commits

131 Branches

446 Tags

325 MiB

Tree: 66b243dd87

Commit Graph

Author	SHA1	Message	Date
ayanamist	b922b5e90d	stream: writes may return false but forget to emit drain If a write is above the highWaterMark, _write still manages to fully send it synchronously, _writableState.length will be adjusted down to 0 synchronously with the write returning false, but 'drain' will not be emitted until process.nextTick. If another small write which is below highWaterMark is issued before process.nextTick happens, _writableState.needDrain will be reset to false, and the drain event will never be fired. So we should check needDrain before setting it up, which prevents it from inproperly resetting to false.	11 years ago

Author

SHA1

Message

Date

ayanamist

b922b5e90d

stream: writes may return false but forget to emit drain

If a write is above the highWaterMark, _write still manages to
fully send it synchronously, _writableState.length will be adjusted down
to 0 synchronously with the write returning false, but 'drain' will
not be emitted until process.nextTick.

If another small write which is below highWaterMark is issued before
process.nextTick happens, _writableState.needDrain will be reset to false,
and the drain event will never be fired.

So we should check needDrain before setting it up, which prevents it
from inproperly resetting to false.

11 years ago

1 Commits (66b243dd87509a7e259bf9bfec1ab31e01620b3e)