lukechilds/node - node - Gitea: Git with a cup of tea

18872 Commits

131 Branches

446 Tags

325 MiB

Tree: 6763fb2f0e

Commit Graph

Author	SHA1	Message	Date
Franziska Hinkelmann	c2c6ae52ea	test: move test-vm-function-redefinition to parallel With the upstream fix in V8, function declarations now work fine in the vm module and the test is no longer failing. Refs: https://codereview.chromium.org/2334733002 Fixes: https://github.com/nodejs/node/issues/548 PR-URL: https://github.com/nodejs/node/pull/9618 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	9 years ago
cjihrig	e38e2a6012	test: bug repro for vm function redefinition This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: https://github.com/nodejs/node/issues/548 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago

Author

SHA1

Message

Date

Franziska Hinkelmann

c2c6ae52ea

test: move test-vm-function-redefinition to parallel

With the upstream fix in V8, function declarations now
work fine in the vm module and the test is no longer failing.

Refs: https://codereview.chromium.org/2334733002
Fixes: https://github.com/nodejs/node/issues/548
PR-URL: https://github.com/nodejs/node/pull/9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

9 years ago

cjihrig

e38e2a6012

test: bug repro for vm function redefinition

This commit adds a failing test case for the vm module.
Currently, if runInContext() defines a function, and a later call
to runInContext() redefines the same function, the original
function is not overwritten.

Refs: https://github.com/nodejs/node/issues/548
PR-URL: https://github.com/nodejs/node/pull/5528
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

9 years ago

1 Commits (6763fb2f0ee4fa663e720a1e37570c8a8e18d03b)