lukechilds/node - node - Gitea: Git with a cup of tea

9817 Commits

131 Branches

446 Tags

325 MiB

Tree: 6d15b163b0

Commit Graph

Author	SHA1	Message	Date
isaacs	f9a0140ef1	http: Handle hangup writes more gently	12 years ago
isaacs	c9dcf5718c	http: Raise hangup error on destroyed socket write Prior to v0.10, Node ignored ECONNRESET errors in many situations. There are valid cases in which ECONNRESET should be ignored as a normal part of the TCP dance, but in many others, it's a very relevant signal that must be heeded with care. Exacerbating this problem, if the OutgoingMessage does not have a req.connection._handle, it assumes that it is in the process of connecting, and thus buffers writes up in an array. The problem happens when you reuse a socket between two requests, and it is destroyed abruptly in between them. The writes will be buffered, because the socket has no handle, but it's not ever going to GET a handle, because it's not connecting, it's destroyed. The proper fix is to treat ECONNRESET correctly. However, this is a behavior/semantics change, and cannot land in a stable branch. Fix #4775	12 years ago

Author

SHA1

Message

Date

isaacs

f9a0140ef1

http: Handle hangup writes more gently

12 years ago

isaacs

c9dcf5718c

http: Raise hangup error on destroyed socket write

Prior to v0.10, Node ignored ECONNRESET errors in many situations.
There *are* valid cases in which ECONNRESET should be ignored as a
normal part of the TCP dance, but in many others, it's a very relevant
signal that must be heeded with care.

Exacerbating this problem, if the OutgoingMessage does not have a
req.connection._handle, it assumes that it is in the process of
connecting, and thus buffers writes up in an array.

The problem happens when you reuse a socket between two requests, and it
is destroyed abruptly in between them.  The writes will be buffered,
because the socket has no handle, but it's not ever going to GET a
handle, because it's not connecting, it's destroyed.

The proper fix is to treat ECONNRESET correctly.  However, this is a
behavior/semantics change, and cannot land in a stable branch.

Fix #4775

12 years ago

2 Commits (6d15b163b090f7dd218843fdca55f874da5daead)