lukechilds/node - node - Gitea: Git with a cup of tea

12575 Commits

131 Branches

446 Tags

325 MiB

Tree: 6f4ab1d1ab

Commit Graph

Author	SHA1	Message	Date
Julien Gilli	88e8d93e14	domains: fix handling of uncaught exceptions Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when: 1. no error handler is set on the domain within which an error is thrown 2. an `'uncaughtException'` event listener is set on the process Also fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. Fixes #3607 and #3653. PR: #3884 PR-URL: https://github.com/nodejs/node/pull/3884 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago

Author

SHA1

Message

Date

Julien Gilli

88e8d93e14

domains: fix handling of uncaught exceptions

Fix node exiting due to an exception being thrown rather than emitting
an `'uncaughtException'` event on the process object when:
1. no error handler is set on the domain within which an error is thrown
2. an `'uncaughtException'` event listener is set on the process

Also fix an issue where the process would not abort in the proper
function call if an error is thrown within a domain with no error
handler and `--abort-on-uncaught-exception` is used.

Fixes #3607 and #3653.

PR: #3884
PR-URL: https://github.com/nodejs/node/pull/3884
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

1 Commits (6f4ab1d1ab774f0f26b0fc2034d31d63838c8cea)