lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
isaacs	b0de1e4a41	stream: Fix unshift() race conditions Fix #5272 The consumption of a readable stream is a dance with 3 partners. 1. The specific stream Author (A) 2. The Stream Base class (B), and 3. The Consumer of the stream (C) When B calls the _read() method that A implements, it sets a 'reading' flag, so that parallel calls to _read() can be avoided. When A calls stream.push(), B knows that it's safe to start calling _read() again. If the consumer C is some kind of parser that wants in some cases to pass the source stream off to some other party, but not before "putting back" some bit of previously consumed data (as in the case of Node's websocket http upgrade implementation). So, stream.unshift() will generally never be called by A, but only called by C. Prior to this patch, stream.unshift() also unset the state.reading flag, meaning that C could indicate the end of a read, and B would dutifully fire off another _read() call to A. This is inappropriate. In the case of fs streams, and other variably-laggy streams that don't tolerate overlapped _read() calls, this causes big problems. Also, calling stream.shift() after the 'end' event did not raise any kind of error, but would cause very strange behavior indeed. Calling it after the EOF chunk was seen, but before the 'end' event was fired would also cause weird behavior, and could lead to data being lost, since it would not emit another 'readable' event. This change makes it so that: 1. stream.unshift() does not set state.reading = false 2. stream.unshift() is allowed up until the 'end' event. 3. unshifting onto a EOF-encountered and zero-length (but not yet end-emitted) stream will defer the 'end' event until the new data is consumed. 4. pushing onto a EOF-encountered stream is now an error. So, if you read(), you have that single tick to safely unshift() data back into the stream, even if the null chunk was pushed, and the length was 0.	12 years ago
Iskren Ivov Chernev	2f4a62c5e1	doc: fix streams2 SimpleProtocol example A non-existing variable `b` was used to queue data for reading.	12 years ago
isaacs	b0f6789a78	stream: Remove bufferSize option Now that highWaterMark increases when there are large reads, this greatly reduces the number of calls necessary to _read(size), assuming that _read actually respects the size argument.	12 years ago
isaacs	426b4c6258	stream: _write takes an encoding argument This vastly reduces the overhead of decodeStrings:false streams, such as net and http.	12 years ago
isaacs	cd68d86c32	stream: Remove output function from _transform Just use stream.push(outputChunk) instead.	12 years ago
Lars-Magnus Skog	4b20f3440d	doc change for Readable._read()	12 years ago
isaacs	fc22986023	doc: Clarify advisory-ness of stream._read() argument	12 years ago
Gil Pedersen	13c8bc8917	doc: Update to reflect new _read() interface	12 years ago
Evan Oxfeld	16ddc545bd	doc: Fix readable.unshift() example Slice the portion of the buffer to unshift back into the read queue	12 years ago
isaacs	4926ffd14b	doc: Provide 2 examples of SimpleProtocol parser The first example uses Readable, and shows the use of readable.unshift(). The second uses the Transform class, showing that it's much simpler in this case.	12 years ago
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	12 years ago
Nathan Rajlich	1ba39226b2	doc: document the writable.end() callback function Support for it was added in `a9c4a20331`.	12 years ago
Raynos	444bbd4fa7	streams: Support objects other than Buffers We detect for non-string and non-buffer values in onread and turn the stream into an "objectMode" stream. If we are in "objectMode" mode then howMuchToRead will always return 1, state.length will always have 1 appended to it when there is a new item and fromList always takes the first value from the list. This means that for object streams, the n in read(n) is ignored and read() will always return a single value Fixed a bug with unpipe where the pipe would break because the flowing state was not reset to false. Fixed a bug with sync cb(null, null) in _read which would forget to end the readable stream	12 years ago
isaacs	a993f740f0	stream: Add readable.push(chunk) method	12 years ago
Andreas Madsen	ce30683012	doc: document the finish event Since the stream implementer is not expected to overwrite .end() the finish event is necessary in order to know when no more data can be written	12 years ago
isaacs	982981442d	doc: Nudge formatting to make json generator happy Starting a line with `bold` text makes it think that it's a link, and get confused. This should really be fixed properly in the doc generator, but for now, it's not a major issue. It's probably just a matter of updating marked.	12 years ago
isaacs	20a88feb8f	docs: streams2	12 years ago
Ben Noordhuis	b0d04ffbd8	doc: stream: clarify meaning of 'drain' some more Courtesy of Lee Coltrane (@coltrane).	12 years ago
Ben Noordhuis	f624be4093	doc: stream: clarify meaning of 'drain' event	12 years ago
isaacs	b90c1502e5	doc: Correct stream.write fd mention No streams actually work this way.	12 years ago
isaacs	559a98f0d7	doc: Formatting and grammar on stream api doc	12 years ago
Dominic Tarr	7accaeb490	correct documentation of Stream#destroy	12 years ago
Ben Kelly	c6185c8484	doc: Improve cross-linking in API docs markdown Cross-link EventEmitter references in API docs to events.html Fix broken cross-reference links with wrong anchor names in API docs.	13 years ago
Ben Noordhuis	05b81f333c	doc: clarify stream 'close' event	13 years ago
Philip Tellis	493beb23f2	doc: fs.ReadableStream does not have a destroySoon method	13 years ago
koichik	9f3c639a9c	doc: fix setEncoding() Fixes #3209.	13 years ago
domenic	5bc07cc90b	doc: note that `stream.pause` is advisory	13 years ago
isaacs	2d44dcc8be	doc: Add stability indicators to documentation	13 years ago
isaacs	7bfa5cf284	s/streams/stream/	13 years ago
isaacs	774c289ba8	doc refactor: streams	13 years ago
isaacs	f9df88c6da	s/streams/stream/	13 years ago
isaacs	03968739c5	doc refactor: streams	13 years ago
koichik	a2cd31cbf1	doc: add the note about 'data' event Refs #2691.	13 years ago
koichik	e1c043f43a	docs: fix docs to not suggest variable leaks Fixes #2106.	13 years ago
Ryan Dahl	239b3d62de	Remove resume and pause events Too complex; unnecessary.	13 years ago
Ryan Dahl	0fec213656	Update docs for server fd sharing	13 years ago
Thomas Shinnick	4cf0ce5bb4	docs: typos and minor edits in several modules Mostly quite minor edits. Those possibly of more interest are: emitter.setMaxListeners(n) That the limit is per event name for an emitter. fs.readlink() Not a path, but rather the symbolic link's string value, which would be at best a partial path, certainly not a 'resolvedPath' global.__filename This may be "well-known" but this is a full path to the module that referencing code is running in. It is not the main program's path, unless you are in the main program. Each module knows only its own path. server.listen(port,...) I actually needed this functionality... "gimme just _any_ next port" stream.end() stream.destroy() Yeah, everybody knows what happens to the queued data, but let's make it really explicit for the first readers.	13 years ago
Elijah Insua	b722aaa8c5	Close #1303 Stream.pipe returns the destination Squashed: * Simple change to make Stream.pipe(destination) return the destination Stream * Test: ensure Stream.pipe(destination) returns the destination Stream * updated Stream.pipe() documentation to reflect that it now returns the destination stream	14 years ago
Zachary Scott	67913a0232	writable stream api has destroySoon() for exiting after data queue has been drained	14 years ago
Ryan Dahl	839fb8e19b	typos	14 years ago
Mikeal Rogers	634e7236f7	Add 'pipe' event	14 years ago
Ryan Dahl	8f23583d10	A few spelling fixes. Thanks Bjarki. Closes GH-561.	14 years ago
Ryan Dahl	b92329667f	Fix spelling mistakes	14 years ago
Ryan Dahl	2957382991	Implement new stream method, destroySoon Still missing on fs.WriteStream	14 years ago
Ryan Dahl	2e3e95ee89	add process.stdin	14 years ago
Ryan Dahl	8f5f213a6f	Revert "Add optional filters to stream.pipe()" This reverts commit `24aded078f`.	14 years ago
Ryan Dahl	24aded078f	Add optional filters to stream.pipe()	14 years ago
Nikhil Marathe	f11291a220	Added documentation for Stream.pipe	14 years ago
Micheil Smith	e190c9616e	Splitting documentation	14 years ago

30 Commits (716176fa997c554e424485897894ec2898f8254f)