Tree: 75c84b2439

Commit Graph

11 Commits (75c84b2439ab85cc3dcd6bcc3ea808cf3d051cf9)

Author	SHA1	Message	Date
Ryan Dahl	9d27faa2c4	Revert "Fix #1801 vm: Use 'sandbox' as global_prototype" Accidentally committed. Revert until review. This reverts commit 200df8641b.	14 years ago
elliottcable	200df8641b	Fix #1801 vm: Use 'sandbox' as global_prototype Squashed commit: (- re tests) Cleaning up the `Script` test suite. For whatever reason, there were several duplicate test files related to `Script` and the `'vm'` module. I removed these, and fixed a few other small issues. (More fixes coming in subsequent commits.) Squashes: 19e86045a0..1e3dcff4eb (api fix:1801 new:1801) `'vm'` module uses sandbox as prototype As described in GH-1801, the `'vm'` module was handling the `sandbox` object provided by the API consumer in a particularly terrible and fragile fashion: it was simply shallow-copying any enumerable properties from the sandbox onto the global context before executing the code, and then eventually copying any values on the global context back into the sandbox object *afterwards*. This commit removes all of that implementation, and utilizes the passed sandbox object as the *prototype of the context* instead. A bit of a hack, but a very effective one. This no longer allows for new variables created in the global context to be placed into your sandbox after execution has completed, but that’s for the best anyway, as it’s not very in line with the concept of a “box of passed-in context.” I’m planning to further implement an interface for API consumers to acquire the *actual global* from within the VM soon, thus allowing for separation-of-concerns: providing data *to* the VM via the sandbox-prototype, and exploring the internal environment of the VM itself. // GitHub cruft: closes #1801 Squashes: 43b8e3c..209ed86	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Oleg Efimov	0ce9cbab29	GJSLint continue	15 years ago
Ryan Dahl	02cc39f221	Check for global leaks in all tests	15 years ago
Ryan Dahl	a0159b4b29	Fix global leaks	15 years ago
Ryan Dahl	8b1082825c	Rename require('javascript') to require('vm')	15 years ago
Ryan Dahl	d787a444c5	Use require('javascript') instead of process.binding('evals')	15 years ago
Ryan Dahl	9fd5e3c89c	Update tests to work with module contexts	15 years ago
Ryan Dahl	f1a4f17897	script.runIn*Context not throwing errors properly.	15 years ago
Herbert Vojcik	c2a06725d6	Script class with eval-function-family in binding('evals') plus tests.	15 years ago