lukechilds/node - node - Gitea: Git with a cup of tea

12566 Commits

131 Branches

446 Tags

325 MiB

Tree: 788541b40c

Commit Graph

Author	SHA1	Message	Date
Evan Lucas	2bb147535e	fs: don't throw in read if buffer too big If the resulting buffer.toString() call in fs.read throws, catch the error and pass it back in the callback. This issue only presents itself when fs.read is called using the legacy string interface: fs.read(fd, length, position, encoding, callback) PR-URL: https://github.com/nodejs/node/pull/3503 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	9 years ago
Evan Lucas	7added3b39	fs: pass err to callback if buffer is too big In fs.readFile, if an encoding is specified and toString fails, do not throw an error. Instead, pass the error to the callback. Fixes: https://github.com/nodejs/node/issues/2767 PR-URL: https://github.com/nodejs/node/pull/3485 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>	9 years ago

Author

SHA1

Message

Date

Evan Lucas

2bb147535e

fs: don't throw in read if buffer too big

If the resulting buffer.toString() call in fs.read throws, catch the
error and pass it back in the callback.

This issue only presents itself when fs.read is called using the legacy
string interface:

fs.read(fd, length, position, encoding, callback)

PR-URL: https://github.com/nodejs/node/pull/3503
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

9 years ago

Evan Lucas

7added3b39

fs: pass err to callback if buffer is too big

In fs.readFile, if an encoding is specified and toString fails, do not
throw an error. Instead, pass the error to the callback.

Fixes: https://github.com/nodejs/node/issues/2767
PR-URL: https://github.com/nodejs/node/pull/3485
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

9 years ago

1 Commits (788541b40c0c9d21d8ea89817ab85b4fcf83bfbc)