lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
isaacs	426b4c6258	stream: _write takes an encoding argument This vastly reduces the overhead of decodeStrings:false streams, such as net and http.	12 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	49ea653363	streams2: Remove pipe if the dest emits error	12 years ago
Felix Geisendörfer	2b91256c61	Fix error handling bug in stream.pipe() Problem: Since stream.pipe() is registering it's own error handlers on the source and destination stream, it needs to replicate the EventEmitter 'error' emitting semantics of throwing an error if there are no other listeners. However, there was a off-by-one error because the check for remaining listeners was done after cleanup() which means the pipe's own listener was no longer included. This would cause 'error' events on either the dest or the source to throw if there was one other error listener, and while swallowing the 'error' event if there was no other listener. Solution: I added a test demonstrating the two issues and fixed the problem by correcting the off-by-one error. Fixes #1095.	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Oleg Efimov	0665f0271e	GJSLint all simple tests exclude http-*, url, path	14 years ago
Ryan Dahl	a0159b4b29	Fix global leaks	14 years ago
Ryan Dahl	604f4fdf8c	Write write.txt into the tmpdir	14 years ago
Ryan Dahl	bbbcd1fee0	Safe constructors for fs.ReadStream and fs.WriteStream	14 years ago
Tobie Langel	ccf4afa256	Do not emit WriteStream's drain event before ws.write has been called.	15 years ago
Tobie Langel	f5e4047064	Avoid closing a WriteStream before it has been opened.	15 years ago