lukechilds/node - node - Gitea: Git with a cup of tea

16599 Commits

131 Branches

446 Tags

325 MiB

Tree: 7d851e3b6a

Commit Graph

Author	SHA1	Message	Date
Zahidul Islam	802a945d81	test: add mustCall in timers-unrefed-in-callback PR-URL: https://github.com/nodejs/node/pull/12594 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>	8 years ago
Shigeki Ohtsu	632aee186d	timers: fix not to close reused timer handle The timer handle is reused when it is unrefed in order to avoid new callback in beforeExit(#3407). If it is unrefed within a setInterval callback, the reused timer handle is closed so that setInterval no longer keep working. This fix does not close the handle in case of setInterval. PR-URL: https://github.com/nodejs/node/pull/11646 Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

Zahidul Islam

802a945d81

test: add mustCall in timers-unrefed-in-callback

PR-URL: https://github.com/nodejs/node/pull/12594
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

8 years ago

Shigeki Ohtsu

632aee186d

timers: fix not to close reused timer handle

The timer handle is reused when it is unrefed in order to avoid new
callback in beforeExit(#3407). If it is unrefed within a setInterval
callback, the reused timer handle is closed so that setInterval no
longer keep working. This fix does not close the handle in case of
setInterval.

PR-URL: https://github.com/nodejs/node/pull/11646
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

2 Commits (7d851e3b6aecac94945496c6148b36aefe82c1db)