lukechilds/node - node - Gitea: Git with a cup of tea

12748 Commits

131 Branches

446 Tags

325 MiB

Tree: 83524b3c18

Commit Graph

Author	SHA1	Message	Date
Michael Dawson	e9e837c64c	test: harden test-child-process-fork-regr-gh-2847 test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/3459	9 years ago
Fedor Indutny	36b969ff44	child_process: `null` channel handle on close `HandleWrap::OnClose` destroys the underlying C++ object and null's the internal field pointer to it. Therefore there should be no references to the wrapping JavaScript object. `null` the process' `_channel` field right after closing it, to ensure no crashes will happen. Fix: https://github.com/nodejs/node/issues/2847 PR-URL: https://github.com/nodejs/node/pull/3041 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	10 years ago

Author

SHA1

Message

Date

Michael Dawson

e9e837c64c

test: harden test-child-process-fork-regr-gh-2847

test-child-process-fork-regr-gh-2847 could fail depending
on timing and how messages were packed into tcp packets.
If all of the requests fit into one packet then the test
worked otherwise, otherwise errors could occur.  This PR
modifies the test to be tolerant while still validating that
some of the connection can be made succesfully

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/3459

9 years ago

Fedor Indutny

36b969ff44

child_process: `null` channel handle on close

`HandleWrap::OnClose` destroys the underlying C++ object and null's the
internal field pointer to it. Therefore there should be no references to
the wrapping JavaScript object.

`null` the process' `_channel` field right after closing it, to ensure
no crashes will happen.

Fix: https://github.com/nodejs/node/issues/2847
PR-URL: https://github.com/nodejs/node/pull/3041
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

10 years ago

2 Commits (83524b3c186e2e1ba2975e3b009ec81b10b641ff)