lukechilds/node - node - Gitea: Git with a cup of tea

18586 Commits

131 Branches

446 Tags

325 MiB

Tree: 86c4655a0f

Commit Graph

Author	SHA1	Message	Date
Sebastiaan Deckers	bb29405904	lib,src: fix consistent spacing inside braces PR-URL: https://github.com/nodejs/node/pull/14162 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Joyee Cheung	474e9d64b5	test: add more test cases of server.listen option * Test listening with different handle and fd * Test listening without callback PR-URL: https://github.com/nodejs/node/pull/11778/ Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago
Joyee Cheung	4775942957	lib, test: fix server.listen error message Previously the error messages are mostly `[object Object]` after the options get normalized. Use util.inspect to make it more useful. Refactor the listen option test, add precise error message validation and a few more test cases. PR-URL: https://github.com/nodejs/node/pull/11693 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	8 years ago

Author

SHA1

Message

Date

Sebastiaan Deckers

bb29405904

lib,src: fix consistent spacing inside braces

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Joyee Cheung

474e9d64b5

test: add more test cases of server.listen option

* Test listening with different handle and fd
* Test listening without callback

PR-URL: https://github.com/nodejs/node/pull/11778/
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

8 years ago

Joyee Cheung

4775942957

lib, test: fix server.listen error message

Previously the error messages are mostly `[object Object]`
after the options get normalized. Use util.inspect to make
it more useful.

Refactor the listen option test, add precise
error message validation and a few more test cases.

PR-URL: https://github.com/nodejs/node/pull/11693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

8 years ago

3 Commits (86c4655a0fbeeaa29c49d5537e190f6cdedfd4d8)