lukechilds/node - node - Gitea: Git with a cup of tea

19157 Commits

131 Branches

446 Tags

325 MiB

Tree: 87ee0b640e

Commit Graph

Author	SHA1	Message	Date
Matteo Collina	b4432888f5	stream: finish must always follow error When _write completes with an Error, 'finish' was emitted before 'error' if the callback was asynchronous. This commit restore the previous behavior. The logic is still less then ideal, because we call the write() callback before emitting error if asynchronous, but after if synchronous. This commit do not try to change the behavior. This commit fixes a regression introduced by: https://github.com/nodejs/node/pull/13195. Fixes: https://github.com/nodejs/node/issues/13812 PR-URL: https://github.com/nodejs/node/pull/13850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago

Author

SHA1

Message

Date

Matteo Collina

b4432888f5

stream: finish must always follow error

When _write completes with an Error, 'finish' was emitted before
'error' if the callback was asynchronous. This commit restore the
previous behavior.
The logic is still less then ideal, because we call the write()
callback before emitting error if asynchronous, but after if
synchronous. This commit do not try to change the behavior.
This commit fixes a regression introduced by:
https://github.com/nodejs/node/pull/13195.

Fixes: https://github.com/nodejs/node/issues/13812
PR-URL: https://github.com/nodejs/node/pull/13850
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

1 Commits (87ee0b640e01209a648418a95174d40610b4026b)