lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Trevor Norris	42df679c45	node, async-wrap: remove MakeDomainCallback C++ won't deoptimize like JS if specific conditional branches are sporadically met in the future. Combined with the amount of code duplication removal and simplified maintenance complexity, it makes more sense to merge MakeCallback and MakeDomainCallback. Additionally, type casting in V8 before verifying what that type is will cause V8 to abort in debug mode if that type isn't what was expected. Fix this by first checking the v8::Value before casting. PR-URL: https://github.com/joyent/node/pull/8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>	10 years ago
Trevor Norris	2593c14131	async-wrap: move MakeCallback to .cc MakeCallback is too large a function to be inlined. Likewise, only having header files will not allow for any part of AsyncWrap to be exposed cleanly via NODE_MODULE_CONTEXT_AWARE_BUILTIN(). PR-URL: https://github.com/joyent/node/pull/8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>	10 years ago
Trevor Norris	b6559553a4	src: remove Async Listener Async Listener was the name of the user-facing JS API, and is being completely removed. Instead low level hooks directly into the mechanism that AL used will be introduced in a future commit. PR-URL: https://github.com/joyent/node/pull/8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>	10 years ago
Ben Noordhuis	8a00961b81	src: mark more destructors with override keyword The previous commits fixed oversights in destructors that should have been marked virtual but weren't. This commit marks destructors from derived classes with the override keyword.	10 years ago
Ben Noordhuis	f874855d2e	src: mark AsyncWrap destructor as virtual Make AsyncWrap::~AsyncWrap() virtual, otherwise it is unsafe to delete a derived class through a pointer to AsyncWrap. Fortunately, we don't do that anywhere right now; this commit is merely a preemptive bug fix.	10 years ago
Ben Noordhuis	5ab87dba73	src: mark empty destructors as default Mark empty destructors as having a default no-op implementation. Remove a few unused constructors and destructors while we are here.	10 years ago
Saúl Ibarra Corretgé	35b9580cd8	dns: introduce lookupService function Uses getnameinfo to resolve an address an port into a hostname and service. Signed-off-by: Fedor Indutny <fedor@indutny.com>	11 years ago
Trevor Norris	4a9af3fecb	async_wrap: add provider types/pass to constructor These will be used to allow users to filter for which types of calls they wish their callbacks to run. Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>	11 years ago
Trevor Norris	63ccfc3536	async_wrap/timers: remove Add/RemoveAsyncListener The ability to add/remove an AsyncListener to an object after its creation was an artifact of trying to get AL working with the domain module. Now that is no longer necessary and other features are going to be implemented that would be affected by this functionality. So the code will be removed for now to simplify the implementation process. In the future this code will likely be reintroduced, but after some other more important matters have been addressed. None of this functionality was documented, as is was meant specifically for domain specific implementation work arounds. Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>	11 years ago
Trevor Norris	646ac18d79	node: AsyncListener use separate storage mechanism Before when an AsyncListener object was created and the "create" callback returned a value, it was necessary to construct a new Object with the same callbacks but add a place for the new storage value. Now, instead, a separate storage array is kept on the context which is used for any return value of the "create" callback. This significantly reduces the number of Objects that need to be created. Also added a flags property to the context to quickly check if a specific callback was available either on the context or on the AsyncListener instance itself. Few other minor changes for readability that were difficult to separate into their own commit. This has not been optimized yet.	11 years ago
Trevor Norris	828f14556e	src: revert domain using AsyncListeners This is a slightly modified revert of `bc39bdd`. Getting domains to use AsyncListeners became too much of a challenge with many edge cases. While this is still a goal, it will have to be deferred for now until more test coverage can be provided.	11 years ago
Trevor Norris	d120d92bfe	base-object: add BaseObject BaseObject is a class that just handles the Persistent handle attached to the class instance. This also removed WeakObject. Reordering the inheritance chain helps prevent unneeded calls on instances that don't call MakeCallback.	11 years ago
Trevor Norris	bc39bdd995	domain: use AsyncListener API The domain module has been switched over to use the domain module API as much as currently possible. There are still some hooks in the EventEmitter, but hopefully we can remove those in the future.	11 years ago
Trevor Norris	efa62fd9cc	node: add AsyncListener support AsyncListener is a JS API that works in tandem with the AsyncWrap class to allow the user to be alerted to key events in the life cycle of an asynchronous event. The AsyncWrap class has its own MakeCallback implementation that core will be migrated to use, and uses state sharing techniques to allow quicker communication between JS and C++ whether the async event callbacks need to be called.	11 years ago

1 2

57 Commits (89425817d05294ea05c9916e54fe85f53859f6ce)