lukechilds/node - node - Gitea: Git with a cup of tea

11480 Commits

131 Branches

446 Tags

325 MiB

Tree: 8b9a1537ad

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Ben Noordhuis	506c7fd40b	test: fix infinite spawn cycle in stdio test Fix parallel/test-stdio-closed introduced in commit `b5f25a9` ("src: ensure that file descriptors 0-2 are valid") to not keep spawning child processes ad infinitum. The test spawns itself as a child process but a missing return statement made the child process spawn itself again, and again, and again. It went unnoticed for some time because the child process exits almost immediately afterwards, i.e. it didn't fill up the process table. The observable effect was an iojs process that was quietly consuming CPU cyles in the background with a PID that was constantly changing. Refs: https://github.com/iojs/io.js/pull/938 PR-URL: https://github.com/iojs/io.js/pull/948 Reviewed-By: Fedor Indutny <fedor@indutny.com>	10 years ago
Ben Noordhuis	b5f25a963c	src: ensure that file descriptors 0-2 are valid Check that stdin, stdout and stderr map to open file descriptors and remap them to /dev/null if that isn't the case. Protects against information leaks or worse when io.js is started with closed stdio file descriptors. PR-URL: https://github.com/iojs/io.js/pull/875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>	10 years ago

Ben Noordhuis

506c7fd40b

test: fix infinite spawn cycle in stdio test

Fix parallel/test-stdio-closed introduced in commit b5f25a9 ("src:
ensure that file descriptors 0-2 are valid") to not keep spawning
child processes ad infinitum.

The test spawns itself as a child process but a missing return statement
made the child process spawn itself again, and again, and again.

It went unnoticed for some time because the child process exits almost
immediately afterwards, i.e. it didn't fill up the process table.  The
observable effect was an iojs process that was quietly consuming CPU
cyles in the background with a PID that was constantly changing.

Refs: https://github.com/iojs/io.js/pull/938
PR-URL: https://github.com/iojs/io.js/pull/948
Reviewed-By: Fedor Indutny <fedor@indutny.com>

10 years ago

Ben Noordhuis

b5f25a963c

src: ensure that file descriptors 0-2 are valid

Check that stdin, stdout and stderr map to open file descriptors and
remap them to /dev/null if that isn't the case.  Protects against
information leaks or worse when io.js is started with closed stdio
file descriptors.

PR-URL: https://github.com/iojs/io.js/pull/875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>

10 years ago

2 Commits (8b9a1537ad5c34c92215660291e962558b6bc8d3)