lukechilds/node - node - Gitea: Git with a cup of tea

15029 Commits

131 Branches

446 Tags

325 MiB

Tree: 8bb346d61a

Commit Graph

Author	SHA1	Message	Date
Santiago Gimeno	bb6d6a677c	test: fix flaky `test-child-process-pass-fd` Listen on random ports instead of using `common.PORT`. Fixes: https://github.com/nodejs/node/issues/8209 PR-URL: https://github.com/nodejs/node/pull/8212 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>	9 years ago
Santiago Gimeno	0884c70535	child_process: workaround fd passing issue on OS X There's an issue on some `OS X` versions when passing fd's between processes. When the handle associated to a specific file descriptor is closed by the sender process before it's received in the destination, the handle is indeed closed while it should remain opened. In order to fix this behaviour, don't close the handle until the `NODE_HANDLE_ACK` is received by the sender. Added `test-child-process-pass-fd` that is basically `test-cluster-net-send` but creating lots of workers, so the issue reproduces on `OS X` consistently. Fixes: https://github.com/nodejs/node/issues/7512 PR-URL: https://github.com/nodejs/node/pull/7572 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago

Author

SHA1

Message

Date

Santiago Gimeno

bb6d6a677c

test: fix flaky `test-child-process-pass-fd`

Listen on random ports instead of using `common.PORT`.

Fixes: https://github.com/nodejs/node/issues/8209
PR-URL: https://github.com/nodejs/node/pull/8212
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

9 years ago

Santiago Gimeno

0884c70535

child_process: workaround fd passing issue on OS X

There's an issue on some `OS X` versions when passing fd's between processes.
When the handle associated to a specific file descriptor is closed by the sender
process before it's received in the destination, the handle is indeed closed
while it should remain opened. In order to fix this behaviour, don't close the
handle until the `NODE_HANDLE_ACK` is received by the sender.
Added `test-child-process-pass-fd` that is basically `test-cluster-net-send` but
creating lots of workers, so the issue reproduces on `OS X` consistently.

Fixes: https://github.com/nodejs/node/issues/7512
PR-URL: https://github.com/nodejs/node/pull/7572
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9 years ago

2 Commits (8bb346d61a83a9283f7446eb20c291e4459be11c)