lukechilds/node - node - Gitea: Git with a cup of tea

16335 Commits

131 Branches

446 Tags

325 MiB

Tree: 8ee236f85a

Commit Graph

Author	SHA1	Message	Date
Rich Trott	5723087cdd	test: refactor test-dgram-membership * match full error message in assert.throws() * wrapped function -> .bind() PR-URL: https://github.com/nodejs/node/pull/11388 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	b766dab81c	test: increase specificity in dgram test Expand error message checking to include the entire error string in test-dgram-membership. PR-URL: https://github.com/nodejs/node/pull/11187 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
Rich Trott	f94ebb00d4	dgram,test: add addMembership/dropMembership tests The only tests for `addMembership()` and `dropMembership()` (from the `dgram` module) were in `test/internet` which means they almost never get run. This adds checks in `test/parallel`. PR-URL: https://github.com/nodejs/node/pull/6753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	9 years ago

Author

SHA1

Message

Date

Rich Trott

5723087cdd

test: refactor test-dgram-membership

* match full error message in assert.throws()
* wrapped function -> .bind()

PR-URL: https://github.com/nodejs/node/pull/11388
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Rich Trott

b766dab81c

test: increase specificity in dgram test

Expand error message checking to include the entire error string in
test-dgram-membership.

PR-URL: https://github.com/nodejs/node/pull/11187
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

Rich Trott

f94ebb00d4

dgram,test: add addMembership/dropMembership tests

The only tests for `addMembership()` and `dropMembership()` (from the
`dgram` module) were in `test/internet` which means they almost never
get run. This adds checks in `test/parallel`.

PR-URL: https://github.com/nodejs/node/pull/6753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

9 years ago

3 Commits (8ee236f85a4890e5a2992c0829fc3a2d3a654ea4)